Use Tag UIDs in snapshot storage paths - #1521
Open
Eitan Yarmush (EItanya) wants to merge 3 commits into
Open
Conversation
Derive tag snapshot destinations and cleanup prefixes from the persisted tag UID. Retain an immutable storage location instead of an in-progress URI so failed copies can be collected independently of their source actor and template. Signed-off-by: Eitan Yarmush <[email protected]>
Replace the removed in-progress snapshot URI at field 3 and regenerate the protobuf bindings and validation code. Backward compatibility with the previous field is not required. Signed-off-by: Eitan Yarmush <[email protected]>
Pause commits the worker release before the watch-fed scheduler cache observes it. Use the existing availability wait before resuming so cache lag cannot produce a spurious no-capacity failure. Signed-off-by: Eitan Yarmush <[email protected]>
2 tasks
| // once snapshot is set, so a tag left with it set names exactly the objects | ||
| // its unfinished create stranded, and deleting the tag collects them. | ||
| string in_progress_snapshot_uri = 3; | ||
| // Immutable base storage location captured when the tag is reserved. Its |
Collaborator
There was a problem hiding this comment.
Can we make this documentation a bit better? Seems very focus on implementation details, but not meant by API consumers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1508
Store tag snapshots at
<base>/atespaces/<atespace>/tags/<tag-uid>. Replacein_progress_snapshot_uriwith immutablestorage_location, so pending and completed tags share UID-based cleanup independent of the source actor or template.Lint and code-generation verification also passed.